Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly mark a symlink as file to remove #1581

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Conversation

frostming
Copy link
Collaborator

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Close #1580

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2022

Codecov Report

Base: 85.19% // Head: 85.20% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7c4d89d) compared to base (d8c4489).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1581   +/-   ##
=======================================
  Coverage   85.19%   85.20%           
=======================================
  Files          91       91           
  Lines        8100     8102    +2     
  Branches     1927     1928    +1     
=======================================
+ Hits         6901     6903    +2     
  Misses        807      807           
  Partials      392      392           
Flag Coverage Δ
unittests 85.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/installers/uninstallers.py 80.82% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit ceea51a into main Dec 26, 2022
@frostming frostming deleted the fix-symlink-removal branch December 26, 2022 01:19
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install.cache caused namespace package to be "removed" when updating
2 participants