Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): hide tasks starting with an underscore from listing #1855

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

noirbizarre
Copy link
Member

@noirbizarre noirbizarre commented Apr 26, 2023

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

This PR is considering the tasks with a name starting with an underscore as internal tasks (helpers for composite...) and hide them from the listing.

@noirbizarre noirbizarre force-pushed the feature/internal-tasks branch from b07793c to 7010d08 Compare April 26, 2023 01:39
Copy link
Collaborator

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@noirbizarre noirbizarre force-pushed the feature/internal-tasks branch from 7010d08 to e38bff0 Compare April 26, 2023 01:44
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (1d6d490) 85.36% compared to head (e38bff0) 85.39%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1855      +/-   ##
==========================================
+ Coverage   85.36%   85.39%   +0.03%     
==========================================
  Files          99       99              
  Lines        9066     9071       +5     
  Branches     1960     1960              
==========================================
+ Hits         7739     7746       +7     
+ Misses        896      895       -1     
+ Partials      431      430       -1     
Flag Coverage Δ
unittests 85.20% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/commands/run.py 93.56% <100.00%> (+0.75%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit dde40d0 into pdm-project:main Apr 26, 2023
@noirbizarre noirbizarre deleted the feature/internal-tasks branch April 26, 2023 04:13
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants