-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sorting case sensitivity in list command (#1973) #1974
Conversation
@dbalabka Can you fix the failing tests? |
@frostming, yes sure. I'm in progress |
You fix makes sense but it seems can't work with the test suite due to the mocking. I will remove the test change and merge. |
Signed-off-by: Frost Ming <[email protected]>
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1974 +/- ##
==========================================
- Coverage 85.24% 85.22% -0.03%
==========================================
Files 99 99
Lines 9367 9367
Branches 2042 2042
==========================================
- Hits 7985 7983 -2
- Misses 937 939 +2
Partials 445 445
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Frost Ming <[email protected]>
Pull Request Checklist
news/
describing what is new.Describe what you have changed in this PR.
Fixed #1973