-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide response body upon HTTP fault with publish #2400
Provide response body upon HTTP fault with publish #2400
Conversation
6e31ada
to
52ebaa7
Compare
for more information, see https://pre-commit.ci
The auto-reformatting by my editor seems legit to me. If not, this code base seems to not configure the appropriate line length then. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2400 +/- ##
==========================================
- Coverage 84.52% 84.50% -0.03%
==========================================
Files 102 102
Lines 10096 10115 +19
Branches 2223 2225 +2
==========================================
+ Hits 8534 8548 +14
- Misses 1085 1089 +4
- Partials 477 478 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@sanmai-NL line length is configured in pyproject.toml, for Ruff, at 120 characters. What tool/config is your editor using to auto-format code? |
Maybe you are not using the proper tool for formatting, we are using ruff-fmt now. |
Off-topic. But my editor still uses Black. It would be ideal if the repository contained an EditorConfig file that matches the Ruff-specific settings. root = true
[*]
charset = utf-8
continuation_indent_size = 2
end_of_line = lf
indent_size = 2
indent_style = space
insert_final_newline = true
max_line_length = 120
quote_type = single
trim_trailing_whitespace = true
rulers = 100
[*.py]
indent_size = 4
max_line_length = 120
profile = black Where |
After your review/comment I'll finish the checkbox tasks in the opening post. |
Pull Request Checklist
news/
describing what is new.Describe what you have changed in this PR.
Debugging the issue described in #2399 was hard, since PDM didn't provide the very helpful response body
{"message":"Validation failed: Description is too long (maximum is 4000 characters)"}
. For some reason, capturing the traffic also didn't work out for me. And resorting to that would require much expertise from users.This enhancement improves things in a straightforward, but simplistic manner. Ideal would be the ability to log all (structured) API endpoint response data to stdout throughout PDM. That would require more investment and architectural redesign.