Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Link collection ignores package-index-binding #2444

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

frostming
Copy link
Collaborator

Fixes #2442

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f06613) 84.45% compared to head (93a394b) 84.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2444      +/-   ##
==========================================
+ Coverage   84.45%   84.47%   +0.02%     
==========================================
  Files         102      102              
  Lines       10157    10160       +3     
  Branches     2228     2227       -1     
==========================================
+ Hits         8578     8583       +5     
+ Misses       1100     1099       -1     
+ Partials      479      478       -1     
Flag Coverage Δ
unittests 84.26% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 766a56b into main Nov 29, 2023
23 checks passed
@frostming frostming deleted the frostming/issue2442 branch November 29, 2023 01:49
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link collection ignores package-index-binding
1 participant