add a PDM_CACHE_DIR environment variable
#2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostming
approved these changes
Dec 12, 2023
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2485 +/- ##
=======================================
Coverage 84.63% 84.63%
=======================================
Files 104 104
Lines 10332 10332
Branches 2257 2257
=======================================
Hits 8744 8744
Misses 1115 1115
Partials 473 473
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Sorry, it was mostly a PoC, I did not expect tests to be green and you to notice so fast. It's done. |
deronnax
changed the title
PDM_CACHE_DIR environment variable
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.
I made
cache_dirconfigurable through an environment variable. Some CI impose some restriction on the location of what can be cached. For example, Gitlab CI mandates that the cache directory be a children of the build directory. Andpdm config cache_diris hardly usable when you have a big CI configuration where many blocs override each others.I saw the
$HOMEtricks recommended by the env var but I think it would break our code base.