Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installers): don't warn when overwriting its own symlink on install with cache enabled (fixes #2502) #2503

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

noirbizarre
Copy link
Member

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code: N/A

Describe what you have changed in this PR.

This PR ensure that pdm does not raise warning on install/update for symlinks it created himself when cache is enabled.

Fixes #2502

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1af8d29) 84.64% compared to head (456c5b0) 84.63%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/pdm/installers/installers.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2503      +/-   ##
==========================================
- Coverage   84.64%   84.63%   -0.01%     
==========================================
  Files         104      104              
  Lines       10335    10336       +1     
  Branches     2258     2259       +1     
==========================================
  Hits         8748     8748              
- Misses       1115     1116       +1     
  Partials      472      472              
Flag Coverage Δ
unittests 84.42% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noirbizarre noirbizarre force-pushed the fix/false-positive-warnings branch from ce5a534 to 456c5b0 Compare December 17, 2023 19:01
@frostming frostming merged commit 2f87b51 into pdm-project:main Dec 18, 2023
18 of 20 checks passed
@noirbizarre noirbizarre deleted the fix/false-positive-warnings branch December 18, 2023 10:08
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False-positive warning when installing/updating with cache enabled
2 participants