Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/group exclusion #2670

Merged
merged 4 commits into from
Mar 8, 2024
Merged

fix/group exclusion #2670

merged 4 commits into from
Mar 8, 2024

Conversation

2e0byo
Copy link
Contributor

@2e0byo 2e0byo commented Mar 7, 2024

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fixes unintuitive behaviour by making --without imply --with :all if no explicit groups given.

What should we do in the case of --with foo --without foo? Currently if I read the logic right we silently drop it.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (1bf5eb1) to head (e16f939).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2670   +/-   ##
=======================================
  Coverage   84.84%   84.84%           
=======================================
  Files         104      104           
  Lines       10293    10295    +2     
  Branches     2235     2236    +1     
=======================================
+ Hits         8733     8735    +2     
  Misses       1099     1099           
  Partials      461      461           
Flag Coverage Δ
unittests 84.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming
Copy link
Collaborator

What groups will be installed if I run pdm install —prod —without abc?

@2e0byo
Copy link
Contributor Author

2e0byo commented Mar 7, 2024

As I understand it, only default. I'll add a test though.

@2e0byo
Copy link
Contributor Author

2e0byo commented Mar 7, 2024

good catch. Fixed.

@frostming frostming merged commit aff56ce into pdm-project:main Mar 8, 2024
21 checks passed
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants