feat: allow updating specific sub-deps with --allow-transitive flag
#2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `--allow-transitive` argument handler to the class `Command` and its `do_update` method in `update.py`. Add logic for updating transitive dependencies in `update.py`. If the specified package is not in `pyproject.toml`, and the '--allow-transitive' flag is used, then try to match the package name with packages in the lock file instead. Ensures transitive dependencies are not written to `pyproject.toml`. Add three tests for `--allow-transitive` flag. Add shell completions for bash, fish, powershell and zshell. Resolves pdm-project#2628 Co-authored-by: Victor Stenmark <[email protected]> Co-authored-by: Ludvig Skare <[email protected]> Co-authored-by: Sebastian Montén <[email protected]> Co-authored-by: Dante Astorga Castillo <[email protected]>
|
The commit is rebased to |
frostming
reviewed
Mar 14, 2024
|
Hi @dantevi can you make modifications to this PR? |
frostming
pushed a commit
that referenced
this pull request
Mar 22, 2024
…#2689) Add the `--allow-transitive` argument handler to the class `Command` and its `do_update` method in `update.py`. Add logic for updating transitive dependencies in `update.py`. If the specified package is not in `pyproject.toml`, and the '--allow-transitive' flag is used, then try to match the package name with packages in the lock file instead. Ensures transitive dependencies are not written to `pyproject.toml`. Add three tests for `--allow-transitive` flag. Add shell completions for bash, fish, powershell and zshell. Resolves #2628 Co-authored-by: Victor Stenmark <[email protected]> Co-authored-by: Ludvig Skare <[email protected]> Co-authored-by: Sebastian Montén <[email protected]> Co-authored-by: Dante Astorga Castillo <[email protected]> Co-authored-by: Rasmus Danielsson <[email protected]> Signed-off-by: Frost Ming <[email protected]>
frostming
pushed a commit
that referenced
this pull request
Mar 22, 2024
…#2689) Add the `--allow-transitive` argument handler to the class `Command` and its `do_update` method in `update.py`. Add logic for updating transitive dependencies in `update.py`. If the specified package is not in `pyproject.toml`, and the '--allow-transitive' flag is used, then try to match the package name with packages in the lock file instead. Ensures transitive dependencies are not written to `pyproject.toml`. Add three tests for `--allow-transitive` flag. Add shell completions for bash, fish, powershell and zshell. Resolves #2628 Co-authored-by: Victor Stenmark <[email protected]> Co-authored-by: Ludvig Skare <[email protected]> Co-authored-by: Sebastian Montén <[email protected]> Co-authored-by: Dante Astorga Castillo <[email protected]> Co-authored-by: Rasmus Danielsson <[email protected]> Signed-off-by: Frost Ming <[email protected]>
frostming
added a commit
that referenced
this pull request
Mar 22, 2024
…#2689) (#2714) * feat: allow updating specific sub-deps with `--allow-transitive` flag (#2689) Add the `--allow-transitive` argument handler to the class `Command` and its `do_update` method in `update.py`. Add three tests for `--allow-transitive` flag. Add shell completions for bash, fish, powershell and zshell. Resolves #2628 Co-authored-by: Victor Stenmark <[email protected]> Co-authored-by: Ludvig Skare <[email protected]> Co-authored-by: Sebastian Montén <[email protected]> Co-authored-by: Dante Astorga Castillo <[email protected]> Co-authored-by: Rasmus Danielsson <[email protected]> * fix: remove code unused Signed-off-by: Frost Ming <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.
copied from commit message:
Add the
--allow-transitiveargument handler to the classCommandand itsdo_updatemethod inupdate.py.Add logic for updating transitive dependencies in
update.py. If the specified package is not inpyproject.toml, and the '--allow-transitive' flag is used, then try to match the package name with packages in the lock file instead. Ensures transitive dependencies are not written topyproject.toml.Add three tests for
--allow-transitiveflag.Add shell completions for bash, fish, powershell and zshell.
Resolves #2628