Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: don't cache the decompressed content of wheels unless being told so #2803

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@frostming frostming linked an issue Apr 12, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 85.03%. Comparing base (bf07ca9) to head (f4c5323).

Files Patch % Lines
src/pdm/installers/manager.py 40.00% 3 Missing ⚠️
src/pdm/models/candidates.py 90.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2803      +/-   ##
==========================================
- Coverage   85.08%   85.03%   -0.06%     
==========================================
  Files         106      106              
  Lines       10622    10579      -43     
  Branches     2309     2298      -11     
==========================================
- Hits         9038     8996      -42     
+ Misses       1108     1106       -2     
- Partials      476      477       +1     
Flag Coverage Δ
unittests 84.81% <88.88%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming linked an issue Apr 12, 2024 that may be closed by this pull request
1 task
@frostming frostming merged commit ec5d7ca into main Apr 12, 2024
20 of 21 checks passed
@frostming frostming deleted the revert/package-cache branch April 12, 2024 03:04
@deronnax
Copy link
Contributor

revert of #2660

@whitequark
Copy link
Contributor

Thanks, I've hit a few issues related to package caching, but never got to the bottom of exactly what was the issue. Requiring explicit opt-in is nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants