-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incompatibility with importlib-metadata 8 #2975
Conversation
Thanks for this fix! I think this might also be related: https://github.com/pydantic/pydantic/actions/runs/9670225358/job/26678546379 (an issue with |
Please fix other occurrences as well, search for (regex) You will also need a compatibility helper function for this to not repeat the try-catch everywhere. |
Thanks @JelleZijlstra, quite speedy 😎! |
Thanks, do you know if it is safe to assume that the "Name" key is always present? That's the one PDM looks at most frequently. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2975 +/- ##
==========================================
- Coverage 85.18% 85.18% -0.01%
==========================================
Files 106 106
Lines 10735 10734 -1
Branches 2347 2347
==========================================
- Hits 9145 9144 -1
Misses 1108 1108
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Not sure what's causing the failure in 3.13 on Windows, but the same failure appeared on #2973, so it's probably not related to my changes. |
Thanks |
Fixes #2974
Pull Request Checklist
news/
describing what is new.Describe what you have changed in this PR.
Still running the test suite locally to verify whether existing tests catch this.