Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't validate requirements that are not used #3377

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

frostming
Copy link
Collaborator

Fixes #3376

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.43%. Comparing base (f0ad0c0) to head (e1bd7f9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/models/requirements.py 61.11% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3377      +/-   ##
==========================================
+ Coverage   85.20%   85.43%   +0.23%     
==========================================
  Files         112      112              
  Lines       11492    11496       +4     
  Branches     2517     2521       +4     
==========================================
+ Hits         9792     9822      +30     
+ Misses       1173     1145      -28     
- Partials      527      529       +2     
Flag Coverage Δ
unittests 85.22% <69.56%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 4821fe5 into main Jan 13, 2025
20 of 21 checks passed
@frostming frostming deleted the frostming/issue3376 branch January 13, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDM sync/install parse all dependencies, regardless if they are included or not
1 participant