Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a new approach of cross-platform resolution #456

Merged
merged 11 commits into from
May 20, 2021

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented May 12, 2021

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@frostming frostming force-pushed the feature/no-marker-merge branch from 64c2c62 to 96a209d Compare May 12, 2021 03:00
@frostming frostming linked an issue May 12, 2021 that may be closed by this pull request
1 task
@frostming frostming force-pushed the feature/no-marker-merge branch from 4e3f858 to 5053f0f Compare May 20, 2021 01:04
@frostming frostming marked this pull request as ready for review May 20, 2021 08:41
@frostming frostming merged commit 8bb3682 into master May 20, 2021
@frostming frostming deleted the feature/no-marker-merge branch May 20, 2021 08:52
@s0undt3ch
Copy link

Sadly what appealed to me, multiplatform requirements, is now gone.

@frostming
Copy link
Collaborator Author

@s0undt3ch Can you elaborate on what you said?

@s0undt3ch
Copy link

I meant the export to requirements files.
It's now platform dependent right?

@frostming
Copy link
Collaborator Author

yes, it is stated in the changelog:
pdm export no longer produces requirements file applicable for all platforms due to the new approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add "pyobjc~=7.2; sys_platform == 'darwin'"
2 participants