Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use installer as the wheel installer #563

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Use installer as the wheel installer #563

merged 3 commits into from
Jul 29, 2021

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented Jul 29, 2021

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021

Codecov Report

Merging #563 (e1f1f8c) into main (cc0468d) will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   84.08%   84.01%   -0.08%     
==========================================
  Files          68       68              
  Lines        5543     5554      +11     
  Branches      978      980       +2     
==========================================
+ Hits         4661     4666       +5     
- Misses        607      613       +6     
  Partials      275      275              
Flag Coverage Δ
unittests 83.86% <66.66%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/models/environment.py 79.19% <30.00%> (-3.17%) ⬇️
pdm/cli/actions.py 75.64% <100.00%> (ø)
pdm/installers/installers.py 96.00% <100.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0468d...e1f1f8c. Read the comment docs.

@frostming frostming merged commit ccc71cb into main Jul 29, 2021
@frostming frostming deleted the new-installer branch July 29, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants