Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Extract environment related code from Candidate #920

Merged
merged 13 commits into from
Feb 17, 2022

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented Feb 17, 2022

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #920 (0e96838) into main (ef0ddee) will decrease coverage by 0.69%.
The diff coverage is 89.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
- Coverage   84.17%   83.48%   -0.70%     
==========================================
  Files          74       74              
  Lines        6447     6472      +25     
  Branches     1333     1340       +7     
==========================================
- Hits         5427     5403      -24     
- Misses        699      751      +52     
+ Partials      321      318       -3     
Flag Coverage Δ
unittests 83.25% <89.87%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/installers/synchronizers.py 84.54% <ø> (-2.28%) ⬇️
pdm/utils.py 75.71% <50.00%> (-2.63%) ⬇️
pdm/models/candidates.py 89.55% <90.62%> (-0.21%) ⬇️
pdm/cli/actions.py 79.94% <100.00%> (+0.11%) ⬆️
pdm/cli/commands/show.py 85.71% <100.00%> (ø)
pdm/cli/utils.py 80.06% <100.00%> (-1.25%) ⬇️
pdm/formats/requirements.py 91.39% <100.00%> (ø)
pdm/installers/manager.py 85.71% <100.00%> (+0.52%) ⬆️
pdm/models/repositories.py 77.63% <100.00%> (ø)
pdm/project/core.py 89.91% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a4fee...0e96838. Read the comment docs.

@frostming frostming merged commit 3248f44 into main Feb 17, 2022
@frostming frostming deleted the refactor/prepared-candidate branch February 17, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants