Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files not being downloaded from S3 #443

Closed
hummingbird1989 opened this issue Jun 1, 2022 · 5 comments
Closed

Files not being downloaded from S3 #443

hummingbird1989 opened this issue Jun 1, 2022 · 5 comments

Comments

@hummingbird1989
Copy link

hummingbird1989 commented Jun 1, 2022

My use-case is as follows:

  • I have a file (filename.txt) with all the cp commands to copy files from an s3 bucket to another filesystem (cp "s3:src" "dst")
  • I'm calling the commands through Python with a subprocess() call as follows:
    • s5cmd run filename.txt

Some files are being downloaded, but some files are not. Is there a way to log any errors or exceptions that might be happening? I tried --log debug, but didn't get anything about the errors

System settings:
Ubuntu 18.04.6 LTS
s5cmd v1.4.0

@ilkinulas
Copy link
Member

Hello
Could you please try the same with the latest s5cmd release? v2.0.0-beta.2

And also could you please share the exit code and output of s5cmd run command (without python subprocess) ?

@hummingbird1989
Copy link
Author

hummingbird1989 commented Jun 28, 2022 via email

@ilkinulas
Copy link
Member

When this issue is closed we will release a stable version. (v2.0.0) (hopefully at the end of this week)

s5cmd should handle most special characters in filenames. Here is a test for # char.

> s5cmd version
v2.0.0-beta.2-7200415

> s5cmd cp test.txt s3://mybucket/test#1.txt
cp test.txt s3://mybucket/test#1.txt
> s5cmd cp s3://mybucket/test#1.txt .
cp s3://mybucket/test#1.txt test#1.txt

@kucukaslan
Copy link
Contributor

kucukaslan commented Jun 28, 2022

Files with a '#' in the name were not being downloaded.

this might be related to #309. In the previous versions (including the current stable version v1.4.0) run subcommand supported inline comments that begins with hash mark (#). This bug is fixed in v2.0.0-beta.2 (by removing inline comment support).

@igungor
Copy link
Member

igungor commented Jun 19, 2023

v2.0.0 fixes this issue. Could you try it please?

@igungor igungor closed this as completed Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants