Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command: add arbitrary metadata support to cp and pipe #621

Merged
merged 20 commits into from
Aug 21, 2023
Merged

command: add arbitrary metadata support to cp and pipe #621

merged 20 commits into from
Aug 21, 2023

Conversation

denizsurmeli
Copy link
Contributor

@denizsurmeli denizsurmeli commented Jul 27, 2023 •
edited
Loading

This PR adds cp and pipe commands to pass arbitrary metadata to object. It uses the the same strategy offered in the aws-cli.

Resolves #537 .

@denizsurmeli denizsurmeli changed the title feat: add arbitrary metadata support to cp command: add arbitrary metadata support to cp Jul 27, 2023
@denizsurmeli denizsurmeli marked this pull request as ready for review July 28, 2023 06:06
@denizsurmeli denizsurmeli requested a review from a team as a code owner July 28, 2023 06:06
@denizsurmeli denizsurmeli requested review from igungor and seruman and removed request for a team July 28, 2023 06:06
@denizsurmeli denizsurmeli changed the title command: add arbitrary metadata support to cp command: add arbitrary metadata support to cp and pipe Jul 28, 2023
seruman
seruman reviewed Aug 18, 2023
View reviewed changes
command/flag.go Outdated Show resolved Hide resolved
command/flag.go Outdated Show resolved Hide resolved
seruman
seruman reviewed Aug 21, 2023
View reviewed changes
command/flag.go Outdated Show resolved Hide resolved
command/flag.go Outdated Show resolved Hide resolved
command/cp.go Outdated Show resolved Hide resolved
command/pipe.go Outdated Show resolved Hide resolved
storage/storage.go Outdated Show resolved Hide resolved
storage/storage.go Outdated Show resolved Hide resolved
seruman
seruman previously approved these changes Aug 21, 2023
View reviewed changes
igungor
igungor reviewed Aug 21, 2023
View reviewed changes
command/cp.go Outdated Show resolved Hide resolved
command/cp.go Outdated Show resolved Hide resolved
command/flag.go Outdated Show resolved Hide resolved
command/flag.go Outdated Show resolved Hide resolved
igungor
igungor previously approved these changes Aug 21, 2023
View reviewed changes
seruman
seruman previously approved these changes Aug 21, 2023
View reviewed changes
@igungor igungor dismissed stale reviews from seruman and themself via 1057348 August 21, 2023 13:59
@igungor igungor merged commit db6b53f into peak:master Aug 21, 2023
@denizsurmeli denizsurmeli mentioned this pull request Sep 3, 2023
Merged
@seruman seruman mentioned this pull request Sep 9, 2023
Open
denizsurmeli added a commit that referenced this pull request Sep 15, 2023
@denizsurmeli
cp,pipe: don't omit some of the metadata flags (#658)
48f7e59 
#657 mentioned that `acl` flag was broken in `v2.2.1`. After looking at
the issue, it was discovered that not only the `acl` flag was broken,
there are couple of more flags that were being omitted during the
mentioned commands, which all of them caused by this faulty
[PR](#621).

Resolves #657.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igungor igungor igungor left review comments

@seruman seruman seruman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support setting arbitrary metadata
3 participants
@denizsurmeli @igungor @seruman