This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
add opportunity for metered/unmetered BillingMethod #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andreschab90
commented
Jun 20, 2017
andreschab90
commented
- metered billingMethod will be used as a default value
- this PR should allow to use the unmetered BillingMethod
fadookie
suggested changes
Jun 20, 2017
step.yml
Outdated
| @@ -52,6 +52,12 @@ inputs: | |||
| summary: "" | |||
| description: "Project ARNs can be obtained using the AWS CLI 'devicefarm list-projects' command." | |||
| is_required: true | |||
| - billing_method: "" | |||
There was a problem hiding this comment.
I think you can change this to billingMethod: "METERED" to set the default to metered as this is probably what most people will be using.
step.yml
Outdated
| opts: | ||
| title: "Billing Method" | ||
| summary: "" | ||
| description: "use METERED or UNMETERED" |
There was a problem hiding this comment.
Can you make this a little more descriptive? How about
"Specifies the billing method for a test run. Use `METERED` for free tier and pay-as-you-go billing, and `UNMETERED` to use pre-paid device slots. See [How to purchase device slots](https://docs.aws.amazon.com/devicefarm/latest/developerguide/how-to-purchase-device-slots.html) for more info."
There was a problem hiding this comment.
thanks. updated
fadookie
reviewed
Jun 20, 2017
step.yml
Outdated
| title: "Billing Method" | ||
| summary: "" | ||
| description: "use METERED or UNMETERED" | ||
| is_required: false |
There was a problem hiding this comment.
also please add this code to make this a drop-down list:
value_options:
- "METERED"
- "UNMETERED"
fadookie
reviewed
Jun 20, 2017
| @@ -283,6 +284,7 @@ fi | |||
| echo_details "* device_farm_project: $device_farm_project" | |||
| echo_details "* test_package_name: $test_package_name" | |||
| echo_details "* test_type: $test_type" | |||
| echo_details "* billing_method: $billing_method" | |||
There was a problem hiding this comment.
also around line 306 please add the following code to validate the expected option was passed:
options=("METERED" "UNMETERED")
validate_required_input_with_options "billing_method" "${billing_method}" "${options[@]}"
|
@fadookie PR is updated. Thanks war your amazing input :-) |
fadookie
approved these changes
Jun 20, 2017
|
👍 great work |
This was referenced Jun 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.