Skip to content

Commit

Permalink
Introduce arithmetic tests
Browse files Browse the repository at this point in the history 
Add tests to validate input, and ensure that we can consume arguments
correctly for arithmetic and produce well-formed output.
  • Loading branch information
@ethomson
ethomson committed Sep 21, 2018
1 parent 9dbfaf7 commit 22a7b0c
Showing 1 changed file with 240 additions and 0 deletions.
240 changes: 240 additions & 0 deletions test/arithmetic.js
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,240 @@
describe('Arithmetic', function() {
describe('Validation', function() {
it('rejects missing operation', function(done) {
request.get('/arithmetic?operand1=21&operand2=21')
.expect(400)
.end(function(err, res) {
expect(res.body).to.eql({ error: "Unspecified operation" });
done();
});
});
it('rejects invalid operation', function(done) {
request.get('/arithmetic?operation=foobar&operand1=21&operand2=21')
.expect(400)
.end(function(err, res) {
expect(res.body).to.eql({ error: "Invalid operation: foobar" });
done();
});
});
it('rejects missing operand1', function(done) {
request.get('/arithmetic?operation=add&operand2=21')
.expect(400)
.end(function(err, res) {
expect(res.body).to.eql({ error: "Invalid operand1: undefined" });
done();
});
});
it('rejects missing operand2', function(done) {
request.get('/arithmetic?operation=add&operand1=21')
.expect(400)
.end(function(err, res) {
expect(res.body).to.eql({ error: "Invalid operand2: undefined" });
done();
});
});
it('rejects operands with invalid sign', function(done) {
request.get('/arithmetic?operation=add&operand1=4.2-1&operand2=4')
.expect(400)
.end(function(err, res) {
expect(res.body).to.eql({ error: "Invalid operand1: 4.2-1" });
done();
});
});
it('rejects operands with invalid decimals', function(done) {
request.get('/arithmetic?operation=add&operand1=4.2.1&operand2=4')
.expect(400)
.end(function(err, res) {
expect(res.body).to.eql({ error: "Invalid operand1: 4.2.1" });
done();
});
});
});

describe('Addition', function() {
it('adds two positive integers', function(done) {
request.get('/arithmetic?operation=add&operand1=21&operand2=21')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: 42 });
done();
});
});
it('adds zero to an integer', function(done) {
request.get('/arithmetic?operation=add&operand1=42&operand2=0')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: 42 });
done();
});
});
it('adds a negative integer to a positive integer', function(done) {
request.get('/arithmetic?operation=add&operand1=21&operand2=-42')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: -21 });
done();
});
});
it('adds two negative integers', function(done) {
request.get('/arithmetic?operation=add&operand1=-21&operand2=-21')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: -42 });
done();
});
});
it('adds an integer to a floating point number', function(done) {
request.get('/arithmetic?operation=add&operand1=2.5&operand2=-5')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: -2.5 });
done();
});
});
});

describe('Subtraction', function() {
it('subtracts two positive integers', function(done) {
request.get('/arithmetic?operation=subtract&operand1=42&operand2=21')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: 21 });
done();
});
});
it('subtracts an integer from itself', function(done) {
request.get('/arithmetic?operation=subtract&operand1=42&operand2=42')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: 0 });
done();
});
});
it('subtracts a larger integer from another', function(done) {
request.get('/arithmetic?operation=subtract&operand1=21&operand2=42')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: -21 });
done();
});
});
it('subtracts a negative integer from a positive integer', function(done) {
request.get('/arithmetic?operation=subtract&operand1=21&operand2=-21')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: 42 });
done();
});
});
it('subtracts an integer from a floating point number', function(done) {
request.get('/arithmetic?operation=add&operand1=-2.5&operand2=5')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: 2.5 });
done();
});
});
});

describe('Multiplication', function() {
it('multiplies two positive integers', function(done) {
request.get('/arithmetic?operation=multiply&operand1=21&operand2=2')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: 42 });
done();
});
});
it('multiplies a positive integer with zero', function(done) {
request.get('/arithmetic?operation=multiply&operand1=21&operand2=0')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: 0 });
done();
});
});
it('multiplies a positive integer and negative integer', function(done) {
request.get('/arithmetic?operation=multiply&operand1=21&operand2=-2')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: -42 });
done();
});
});
it('multiplies two negative integers', function(done) {
request.get('/arithmetic?operation=multiply&operand1=-21&operand2=-2')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: 42 });
done();
});
});
it('multiplies two floating point numbers', function(done) {
request.get('/arithmetic?operation=multiply&operand1=.5&operand2=0.5')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: 0.25 });
done();
});
});
});

describe('Division', function() {
it('divides a positive integer by an integer factor ', function(done) {
request.get('/arithmetic?operation=divide&operand1=42&operand2=2')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: 21 });
done();
});
});
it('divides a negative integer by an integer factor ', function(done) {
request.get('/arithmetic?operation=divide&operand1=-42&operand2=2')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: -21 });
done();
});
});
it('divides a positive integer by a non-factor', function(done) {
request.get('/arithmetic?operation=divide&operand1=21&operand2=42')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: 0.5 });
done();
});
});
it('divides a positive integer by a negative integer', function(done) {
request.get('/arithmetic?operation=divide&operand1=21&operand2=-42')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: -0.5 });
done();
});
});
it('divides zero by a positive integer', function(done) {
request.get('/arithmetic?operation=divide&operand1=0&operand2=42')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: 0 });
done();
});
});
it('divides by zero', function(done) {
request.get('/arithmetic?operation=divide&operand1=0.5&operand2=2')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: 0.25 });
done();
});
});
it('divides by zero', function(done) {
request.get('/arithmetic?operation=divide&operand1=21&operand2=0')
.expect(200)
.end(function(err, res) {
expect(res.body).to.eql({ result: null });
done();
});
});
});
});

0 comments on commit 22a7b0c

Please sign in to comment.