Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add write real test section into writing your first test page #37

Merged
merged 8 commits into from
Feb 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 12, 2021

As described in the title.

@ghost ghost requested a review from pedrohyvo February 12, 2021 12:28
@ghost ghost requested a review from pedrohyvo February 12, 2021 19:15
@ghost ghost force-pushed the writing-first-test-real-test branch from 45f6c2f to 555d596 Compare February 12, 2021 19:16
Copy link
Owner

@pedrohyvo pedrohyvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucastfa-toptal just left few comments. After that it's ready to be merged

Lucas Avila and others added 3 commits February 14, 2021 21:21
Co-authored-by: Pedro Hyvo <[email protected]>
Co-authored-by: Pedro Hyvo <[email protected]>
@ghost ghost requested a review from pedrohyvo February 15, 2021 00:23
@pedrohyvo pedrohyvo merged commit 6f223e6 into master Feb 16, 2021
@pedrohyvo pedrohyvo deleted the writing-first-test-real-test branch February 16, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant