Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: core-concepts-writing-and-organizing-tests #58

Merged
merged 14 commits into from
Mar 17, 2021
Merged

doc: core-concepts-writing-and-organizing-tests #58

merged 14 commits into from
Mar 17, 2021

Conversation

rafaabc
Copy link
Contributor

@rafaabc rafaabc commented Mar 8, 2021

@pedrohyvo Tradução finalizada. Qualquer dúvida estou à disposição.

@pedrohyvo pedrohyvo requested a review from a user March 8, 2021 14:33
@pedrohyvo pedrohyvo mentioned this pull request Mar 8, 2021
Open
70 tasks
ghost
ghost suggested changes Mar 8, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obrigado pela contribuição! Adicionei alguns comentários, a maioria relacionada a uma prática que adotamos aqui de adicionar TODOs próximo a links ainda não traduzidos para que fique fácil localizar e substituir pelo link traduzido futuramente.

@pedrohyvo
Copy link
Owner

@rafaabc sempre que você resolver alguma "requested change" você tem que resolver as issues pra ficar melhor na visualização do PR. Outra coisa, você precisa adicionar a página no README também, seguindo o padrão das outras páginas.

pedrohyvo
pedrohyvo requested changes Mar 11, 2021
View reviewed changes
Copy link
Owner

@pedrohyvo pedrohyvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deixei mais alguns comentários @rafaabc

@rafaabc rafaabc requested review from a user and pedrohyvo March 12, 2021 19:19
pedrohyvo
pedrohyvo approved these changes Mar 13, 2021
View reviewed changes
Copy link
Owner

@pedrohyvo pedrohyvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @rafaabc, it looks good to me. Thank you so much 🚀 🍰

@pedrohyvo
Copy link
Owner

@all-contributors please add @rafaabc for code

@allcontributors allcontributors bot mentioned this pull request Mar 13, 2021
Merged
@allcontributors
Copy link
Contributor

@pedrohyvo

I've put up a pull request to add @rafaabc! 🎉

@pedrohyvo
Copy link
Owner

@rafaabc coloquei apenas um comentário sobre o vídeo do AssertJS e gostaria que você atualizasse a sua master com a do repositório, pode ser? Após isso, já faço o merge de uma vez 🚀 🚀 🚀

@pedrohyvo pedrohyvo merged commit 2d05027 into pedrohyvo:master Mar 17, 2021
@pedrohyvo
Copy link
Owner

@rafaabc tudo certo! Parabéns pela contribuição e está pronto para pegar mais uma página 😄 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrohyvo pedrohyvo pedrohyvo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaabc @pedrohyvo