Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Installing Cypress page #6

Merged
merged 36 commits into from
Feb 1, 2021
Merged

Add Installing Cypress page #6

merged 36 commits into from
Feb 1, 2021

Conversation

pedrohyvo
Copy link
Owner

@pedrohyvo pedrohyvo commented Jan 25, 2021

Here's the first translated page under Getting Started section.
Closes #5

@pedrohyvo pedrohyvo requested a review from wlsf82 January 25, 2021 21:26
@pedrohyvo
Copy link
Owner Author

@wlsf82 can you review this PR, please?

@pedrohyvo pedrohyvo requested a review from wlsf82 January 26, 2021 22:33
@pedrohyvo pedrohyvo added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Jan 26, 2021
@pedrohyvo pedrohyvo self-assigned this Jan 26, 2021
@wlsf82
Copy link
Collaborator

wlsf82 commented Jan 29, 2021

Hi, @pedrohyvo 👋

Just to keep you posted, I'll review this PR during the weekend.

Copy link
Collaborator

@wlsf82 wlsf82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @pedrohyvo 👋

I noticed that there are many unresolved conversations. Do you intend to resolve them?

@pedrohyvo pedrohyvo requested a review from wlsf82 February 1, 2021 14:46
Copy link
Collaborator

@wlsf82 wlsf82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrohyvo, as I mentioned in my previous review, there are still many unresolved conversations.

@pedrohyvo pedrohyvo requested a review from wlsf82 February 1, 2021 17:04
@pedrohyvo
Copy link
Owner Author

@wlsf82 now I pushed all requested changes, hope it will works now. 🤞

Copy link
Collaborator

@wlsf82 wlsf82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@wlsf82
Copy link
Collaborator

wlsf82 commented Feb 1, 2021

Great job, @pedrohyvo!

Feel free to squash and merge.

@pedrohyvo pedrohyvo merged commit ee6d48a into master Feb 1, 2021
@pedrohyvo pedrohyvo deleted the getting-started branch February 1, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add installing cypress section
2 participants