Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] private info sealing feature 5 #661

Merged
merged 8 commits into from
Jan 23, 2024
Merged

[FEAT] private info sealing feature 5 #661

merged 8 commits into from
Jan 23, 2024

Conversation

Paul2021-R
Copy link
Contributor

변경 사항

  • 유효성 검사 및 테스트를 통해 정상 작동 여부까지 확인 완료 되었습니다.
  • 유효성 검사의 방식은 자동 생성 생성자가 아닌 수동으로 제작하는 방식으로 하며, 일단은 기존의 유효성 검사 설정된 것들을 수동으로 넣고 Exception 처리 하였습니다.




테스트 결과

@Paul2021-R Paul2021-R added the enhancement New feature or request label Jan 21, 2024
@Paul2021-R Paul2021-R self-assigned this Jan 21, 2024
@sinryuji
Copy link
Collaborator

🎉 @sinryuji 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

@sinryuji sinryuji self-requested a review January 21, 2024 22:45
@Paul2021-R Paul2021-R changed the title 612 refactor private info sealing feature 5 [REFACTOR] private info sealing feature 5 Jan 21, 2024
@Paul2021-R Paul2021-R changed the title [REFACTOR] private info sealing feature 5 [FEAT] private info sealing feature 5 Jan 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

10 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sinryuji
sinryuji approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@sinryuji sinryuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validation 구현 확인하였습니다

@Paul2021-R Paul2021-R merged commit 5cd1851 into dev Jan 23, 2024
0 of 3 checks passed
@Paul2021-R Paul2021-R deleted the 612-refactor-private-info-sealing-feature-5 branch January 23, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinryuji sinryuji sinryuji approved these changes

Assignees

@Paul2021-R Paul2021-R

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Paul2021-R @sinryuji