Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] main page favorite feature #760

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Conversation

weejihye
Copy link
Contributor

@weejihye weejihye commented Feb 3, 2024

변경 사항

  • boolean 배열로 반환하던 내용을 RecruitFavoriteResponse 안에 recruit_id와 함께 담아서 반환
  • 메인페이지 RecruitList 조회시 favorite의 boolean 값 추가
  • favorite 단건 조회 api 추가



테스트 결과

@sinryuji
Copy link
Collaborator

sinryuji commented Feb 3, 2024

🎉 @wochae 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

@sinryuji sinryuji requested a review from wochae February 3, 2024 03:20
Copy link

sonarqubecloud bot commented Feb 3, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@Paul2021-R Paul2021-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다..!

recruit2.getId(),
user != null && recruitFavoriteRepository
.existsByUserIdAndRecruitIdAndType(user.getId(), recruit2.getId(), RecruitFavoriteEnum.LIKE))
).collect(Collectors.toList());

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리슽ㅡ로 리펙토링 된것들 확인했습니다...!

@weejihye weejihye merged commit 4f0e3a5 into dev Feb 3, 2024
5 checks passed
@weejihye weejihye deleted the hotfix-main-page-favorite branch February 5, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants