Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix message numbering failed and Add skill tag decoder #814

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Fix message numbering failed and Add skill tag decoder #814

merged 3 commits into from
Feb 7, 2024

Conversation

Paul2021-R
Copy link
Contributor

변경 사항

  • 메시지를 전달할 때 읽지 않은 경우 그 숫자를 표시해주는 기능을 넣었으나, 해당 기능이 프로필에서 보낼 때 정상적이지 않게 숫자가 카운팅됨.
  • 이에 수정함
  • 스킬 태그 추가 수정으로 특수문자 변환되서 들어오는 값을 인코딩하여 수정하는 메소드 추가하여 테스트까지 마무리




테스트 결과

@Paul2021-R Paul2021-R self-assigned this Feb 7, 2024
@sinryuji
Copy link
Collaborator

sinryuji commented Feb 7, 2024

🎉 @wochae 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

@sinryuji sinryuji requested a review from wochae February 7, 2024 06:46
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sinryuji
sinryuji approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@sinryuji sinryuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메세지 읽지 않은 숫자, 태그 인코딩 확인하였습니다

@Paul2021-R Paul2021-R merged commit 68192c5 into release-1.0.2 Feb 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinryuji sinryuji sinryuji approved these changes

@wochae wochae Awaiting requested review from wochae

Assignees

@Paul2021-R Paul2021-R

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Paul2021-R @sinryuji