Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix 1.0.2 update role max value when recruit is update #819

Conversation

weejihye
Copy link
Contributor

@weejihye weejihye commented Feb 7, 2024

변경 사항

모집글에서 role update 로직을 삭제하고 max값을 study역할값에 집어 넣는 로직을 추가하였습니다.
해당 역할 변경 관련 로직은 이후 버전에서 개선이 필요합니다.




테스트 결과

@weejihye weejihye self-assigned this Feb 7, 2024
@sinryuji
Copy link
Collaborator

sinryuji commented Feb 7, 2024

🎉 @Paul2021-R 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

@sinryuji sinryuji requested a review from Paul2021-R February 7, 2024 07:14
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link
Contributor

@Paul2021-R Paul2021-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인완료.

@weejihye weejihye merged commit bd66b6c into release-1.0.2 Feb 7, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants