Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Request 로깅 수정 #834

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

sinryuji
Copy link
Collaborator

@sinryuji sinryuji commented Feb 8, 2024

변경 사항

게시글 종류의 요청의 경우 Respons 로깅에 result를 표현할 경우 로그가 너무 비대해져서 Response 로깅을 삭제하고 소요시간을 Request 로깅에 넣도록하고 항상 Request 로그를 찍도록 수정하였습니다.




테스트 결과

@sinryuji sinryuji self-assigned this Feb 8, 2024
@sinryuji
Copy link
Collaborator Author

sinryuji commented Feb 8, 2024

🎉 @wochae 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

@sinryuji sinryuji requested a review from wochae February 8, 2024 07:36
Copy link

sonarqubecloud bot commented Feb 8, 2024

Copy link
Contributor

@Paul2021-R Paul2021-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requst 로깅 수정, 내용 많이 줄어든 것 확인하였습니다.

@sinryuji sinryuji merged commit 521c8ed into release-1.0.3 Feb 8, 2024
5 checks passed
@sinryuji sinryuji deleted the refactor-logging branch February 8, 2024 10:37
Copy link
Collaborator

@wochae wochae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response는 결과값이라 로그가 너무 비대해지기 때문에 삭제,
Request 로깅에 소요시간을 추가,
항상 Request 로그를 찍도록 수정.
확인했습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants