Feature string validators #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 13, 2015 09:23
Add tests to check whether an length validator has been added
|
Or @jhnns ? |
| } | ||
| }); | ||
|
|
||
| expect(schema.validators.name).to.be.an("array"); |
There was a problem hiding this comment.
Just a small thing, but I think it should be: expect(schema.validators.name).to.be("array");, because name should not be an array, but it should be the string "array". The test is ok though, it's just for the developer.
|
That's a nice feature, but it should not be restricted to strings. Everything with a length attribute should be validatable. |
|
Actually the |
added 5 commits
August 25, 2015 11:15
Naming should be general if appropriate
Apply proper operation
Make sure there is an lengthable which could be evaluated
|
Nice! That's pretty close to mongoose! Thanks! |
|
Looks good! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #23
@meaku could you please review the code?