Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change for ts plugin when moving from peggy 1.1.0 to 1.2.0 #169

Closed
pjmolina opened this issue Jul 2, 2021 · 0 comments · Fixed by #176
Closed

Breaking change for ts plugin when moving from peggy 1.1.0 to 1.2.0 #169

pjmolina opened this issue Jul 2, 2021 · 0 comments · Fixed by #176

Comments

@pjmolina
Copy link

pjmolina commented Jul 2, 2021

Hi.
I am the maintainer of ts-pegjs to generate a TypeScript parser relaying on peggy.
Noticed that from moving from peggy 1.1.0 to 1.2.0 the following functions were internalized (make private, before were public):

  • stringEscape() and
  • regexpClassEscape()

My code relies on calling this functionality. See here. It could be nice if peggy could keep it public to make it DRY for all and avoid code repetition between core lib and plugins.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant