-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Parens create a pluck context #398
Comments
Parens also create a |
I figured I'd fix 398 while I was in there. |
Oh, BTW, do you remember when it was introduced? I remember at least old versions of PEG.js didn't have this kind of scoping. |
Probably in 2.0. It's been in for a while, but definitely after we forked. |
It was 1.1: Line 371 in dfca04c
|
Thanks! It was one of the larger improvements to DX, but I didn't know it happened after the fork. |
It was technically after the fork, because we forked from the last-known-good spot, then the plucks were back-ported from head -- because that was the feature I wanted to be released enough to want the fork. :) |
It's not clear from the docs that this is legal:
because the parens create a new context for returns. Same with the old way:
The text was updated successfully, but these errors were encountered: