Make test build deterministic #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why I didn't reply to this when you posted it, this is a great change. Please add a CHANGELOG.md entry, and I'll merge. |
markw65
force-pushed
the
deterministic-tests
branch
from
7b2eb79 to
18a0f4c
Compare
|
Quick rebase of CHANGELOG here, please, then ready to go. |
markw65
force-pushed
the
deterministic-tests
branch
from
18a0f4c to
f69e6dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time I build, I get a new version of
docs/js/test-bundle-min.js. It seems to be caused by@rollup/plugin-multi-entryfinding finding its inputs non-deterministically.Instead of supplying a glob pattern for
input, explicitly run glob and provide a sorted array.docs/js/test-bundle-min.jsno longer changes unless the source code changes.I'm not quite sure how to test this - I ran
npm run build:notidythennpm run test:weband it seemed to work the same as before.