Allow returning Geonames results from /reverse
#1045
Merged
+55
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error message is updated to mention the coarse-reverse only nature of Geonames support removal. It also links to the [tracking ticket](pelias/acceptance-tests#447) for Geonames removal which should help provide more context to users.
ghost
added
the
dianashk
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the eventual goal for our
/reverseendpoint is to only allow returning administrative results and addresses, the/nearbyendpoint that would compliment it and allow users to see venues near a given coordinate is not yet production ready.Until it is we want to be able to return Geonames venues, especially since we still can return OSM venues. However, we were returning an incorrect error message that prevented this.
This PR makes that error message only appear when a user tries to return coarse Geonames results from
/reverse, which is no longer possible since there aren't really many geometries in Geonames at all.It also points users who do see the error to our new Geonames removal issue for more context.
Fixes #930
Connects pelias/acceptance-tests#447