Upgrade to pelias-config-5.0.0 (set api.targets.auto_discover to true by default)
#1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the default value of `api.targets.auto_discover` to true, allowing Pelias users to more conveniently work with custom data.
Now that `auto_detect` is set to true, we can simplify this documentation a bit. Most people will have no troubles and we don't have to make the warnings sound quite as scary.
orangejulius
force-pushed
the
auto-discover-true
branch
from
937c46c to
97adb2d
Compare
|
FYI, this turned out to be a breaking change for us. We discovered it yesterday that all our autocomplete API calls with |
|
Hi @gb-kpatel, I imagine what's happened is you don't have any records in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in version 5.0.0 of pelias/config, which brings in a new default value for the
api.targets.auto_discoverconfiguration property.Setting this value to true by default (the new setting) will mean that most Pelias users have to do less work to correctly configure Pelias if they're using custom data that includes their own sources and layers.
As part of this change I've also updated the documentation in the API's README.md around this option and related configuration options. Now that the default behavior is also the recommended behavior, we can simplify things quite a bit and remove a few strongly worded warnings. :)
I took a look at most of our
pelias.jsonconfigurations out there, such as those from pelias/docker and many, but not all of them already setapi.targets.auto_discoverto true, so this configuration change is well tested and hopefully won't cause any issues.