Adjust autocomplete focus boost #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trescube
approved these changes
Nov 17, 2016
This lowers the autocomplete focus boost from 40 to 15. The idea is that, because the boost for population is 20, the focus can't possibly override a popular city, but it can come close. On our default dev build, no acceptance tests fail but the san francisco autocomplete test now passes! It's not clear if this fixes WOF venue issues yet, since the latest build there failed :(
orangejulius
force-pushed
the
adjust_autocomplete_focus_boost
branch
from
1c16d0c to
abb4fa6
Compare
|
There are more tweaks on deck on my machine that help with WOF venue things, but these changes are also good (and we can always tweak them later). I'd prefer to merge the WOF venue compatible changes along with this change, but since there are some other high priority things to do that may block that, and this is ready to go, we'll just merge it as is. |
orangejulius
added a commit
to pelias/acceptance-tests
that referenced
this pull request
Feb 28, 2017
This was fixed with pelias/api#729 some time ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lowers the autocomplete focus boost from 40 to 15. The idea is
that, because the boost for population is 20, the focus can't possibly
override a popular city, but it can come close.
On our default dev build, no acceptance tests fail but the san francisco
autocomplete test now passes!
It's not clear if this fixes WOF venue issues yet, since the latest
build there failed, so stay tuned :(