-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding Bangladesh in pelias #298
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your contribution.
Could you please remove the empty sections in pelias.json
and add some unit tests as per the other countries.
After that I'd be happy to merge this PR.
"interpolation": { "url": "http://interpolation:4300" }, | ||
"libpostal": { "url": "http://libpostal:4400" } | ||
}, | ||
"defaultParameters": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this section defaultParameters
"files": [ | ||
] | ||
}, | ||
"csv": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this empty section csv
"adminLookup": { | ||
"enabled": true | ||
}, | ||
"blacklist": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this empty section blacklist
"importPlace": [ | ||
] | ||
}, | ||
"interpolation": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this empty section interpolation
👋 Hi, I have started a project to onboard Bangladesh in Pelias and start improving address system for Bangladesh. appreciate your help!