tag_mapper: skip inherited enumerable properties #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I haven't touched this code in a while so I wasn't quite sure where the fix would end up. Looks like the right place. If you think any of the other |
|
alrighty, not the most enjoyable task of the week 😆 but I've added 1c9b836 which replaces all usages of the in operator / for ... in syntax. the nice thing about this repo is we have pretty decent unit test coverage and the |
missinglink
force-pushed
the
native_code
branch
from
36bfd97 to
1c9b836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was interested in #557, it seems that we are using the in operator / for ... in syntax which iterates over all properties "including inherited enumerable properties".
A quick
git grepshows other usages of that syntax in this lib which might need attention too.closes #557