Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NL: recognise 'sngl' as abbr for 'singel' without full stop #165

Closed
emacgillavry opened this issue Sep 4, 2022 · 1 comment · Fixed by #166
Closed

NL: recognise 'sngl' as abbr for 'singel' without full stop #165

emacgillavry opened this issue Sep 4, 2022 · 1 comment · Fixed by #166
Labels
bug Something isn't working

Comments

@emacgillavry
Copy link
Contributor

Abbreviated street names referring to '-singel', e.g. Blekerssngl, Gouda or Herensngl, Haarlem are only recognised as street names when there is a full stop at the end: Blekerssngl., Gouda or Herensngl., Haarlem.

Suggested change: add singel|sngl to the concatenated_suffixes_separable.txt file, as 'singel' also works as a street name by itself, e.g. Singel, Amsterdam.
@emacgillavry emacgillavry added the bug Something isn't working label Sep 4, 2022
emacgillavry added a commit to webmapper/parser that referenced this issue Sep 4, 2022
@emacgillavry
Fix full stop error for '-singel' (pelias#165)
aa230af
@emacgillavry emacgillavry mentioned this issue Sep 4, 2022
Merged
2 tasks
@missinglink
Copy link
Member

👍 this seems safe to me, -sngl is an uncommon suffix and unlikely to cause undesired consequences.

missinglink pushed a commit that referenced this issue Sep 6, 2022
@emacgillavry
feat(nl): Fix full stop error for '-singel' (#165) (#166)
016cdf2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix full stop error for '-singel' webmapper/parser
2 participants
@missinglink @emacgillavry