Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full stop error for '-singel' #166

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

emacgillavry
Copy link
Contributor

👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.


Here's the reason for this change 🚀


Here's what actually got changed 👏

  • add singel|sngl to concatenated_suffixes_separable.txt
  • add example Blekerssngl, Gouda as a testcase

Here's how others can test the changes 👀

  • Without the change, both Blekerssingel, Gouda and Herensngl., Haarlem would pass, but Weerdsngl, Utrecht without a full stop indicating the abbreviation would not pass.
  • With this PR, all the variations mentioned above do pass

@missinglink missinglink merged commit 016cdf2 into pelias:master Sep 6, 2022
@emacgillavry emacgillavry deleted the 165-singel-full-stop branch November 23, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NL: recognise 'sngl' as abbr for 'singel' without full stop
2 participants