-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Romanian language to list of languages using street prefix #114
Conversation
Looks like a good change. @missinglink should we bring in the rest of the values from https://github.com/pelias/api/blob/master/middleware/localNamingConventions.js? |
Looks great thanks @taygun It would be super helpful if we had a few example addresses from Romania in our test suite. Here's an example of some recent additions for Czech Republic: |
@orangejulius that functionality is actually different although the list might have some common country codes. This issue is for |
Great @missinglink, I will add a few examples from Romania today. |
I wonder if this list should probably contain all (or most of) the latin based languages. Italian (it) should be added for sure. Also |
Yeah definitely, that would be great to have. I think it would be better to do that in another PR so this one can stay focussed on Romania and we can get it merged today. I know it's a fair bit of work but having at least one or two example addresses for each of those countries is super useful for future reference. |
I'm also confusing myself here, these are language codes not country codes, but it makes sense to include tests from a country which uses each language. |
fantastic thanks! |
this change has been published as |
Thank you also for an amazing project! |
Improvements include: - Better support for Romanian language: pelias/parser#114 - Remove some minor cases of incorrect venue classification in addresses: pelias/parser#115 - Remove "art" as street type: pelias/parser#116
Improvements include: - Better support for Romanian language: pelias/parser#114 - Remove some minor cases of incorrect venue classification in addresses: pelias/parser#115 - Remove "art" as street type: pelias/parser#116
Improvements include: - Better support for Romanian language: pelias/parser#114 - Remove some minor cases of incorrect venue classification in addresses: pelias/parser#115 - Remove "art" as street type: pelias/parser#116
In Romania street types are used as prefix https://www.openstreetmap.org/#map=17/44.43396/26.01652