Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Romanian language to list of languages using street prefix #114

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

taygun
Copy link
Contributor

@taygun taygun commented Jul 20, 2020

In Romania street types are used as prefix https://www.openstreetmap.org/#map=17/44.43396/26.01652

@orangejulius
Copy link
Member

Looks like a good change. @missinglink should we bring in the rest of the values from https://github.com/pelias/api/blob/master/middleware/localNamingConventions.js?

@missinglink
Copy link
Member

Looks great thanks @taygun

It would be super helpful if we had a few example addresses from Romania in our test suite.

Here's an example of some recent additions for Czech Republic:
https://github.com/pelias/parser/blob/master/test/address.cze.test.js

@missinglink
Copy link
Member

@orangejulius that functionality is actually different although the list might have some common country codes.

This issue is for Foo Ave vs Ave Foo whereas the Pelias country code list you linked is for 1 Foo Ave vs. Foo Ave 1.

@taygun
Copy link
Contributor Author

taygun commented Jul 22, 2020

Looks great thanks @taygun

It would be super helpful if we had a few example addresses from Romania in our test suite.

Here's an example of some recent additions for Czech Republic:
https://github.com/pelias/parser/blob/master/test/address.cze.test.js

Great @missinglink, I will add a few examples from Romania today.

@bboure
Copy link
Member

bboure commented Jul 22, 2020

I wonder if this list should probably contain all (or most of) the latin based languages. Italian (it) should be added for sure. Also gl (Galician)

@missinglink
Copy link
Member

Yeah definitely, that would be great to have.

I think it would be better to do that in another PR so this one can stay focussed on Romania and we can get it merged today.

I know it's a fair bit of work but having at least one or two example addresses for each of those countries is super useful for future reference.

@missinglink
Copy link
Member

I'm also confusing myself here, these are language codes not country codes, but it makes sense to include tests from a country which uses each language.

@missinglink
Copy link
Member

fantastic thanks!

@missinglink missinglink merged commit 172fac1 into pelias:master Jul 22, 2020
@missinglink
Copy link
Member

this change has been published as npm version 1.54.0

@taygun
Copy link
Contributor Author

taygun commented Jul 22, 2020

fantastic thanks!

Thank you also for an amazing project!

@taygun taygun deleted the romania-street-prefix branch July 22, 2020 10:30
orangejulius added a commit to pelias/api that referenced this pull request Aug 12, 2020
Improvements include:
- Better support for Romanian language: pelias/parser#114
- Remove some minor cases of incorrect venue classification in addresses: pelias/parser#115
- Remove "art" as street type: pelias/parser#116
orangejulius added a commit to pelias/api that referenced this pull request Aug 25, 2020
Improvements include:
- Better support for Romanian language: pelias/parser#114
- Remove some minor cases of incorrect venue classification in addresses: pelias/parser#115
- Remove "art" as street type: pelias/parser#116
orangejulius added a commit to pelias/api that referenced this pull request Oct 14, 2020
Improvements include:
- Better support for Romanian language: pelias/parser#114
- Remove some minor cases of incorrect venue classification in addresses: pelias/parser#115
- Remove "art" as street type: pelias/parser#116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants