Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(wof_extract) Remove dependency on gnu parallel" #143

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

Joxit
Copy link
Member

@Joxit Joxit commented Oct 9, 2018

Reverts #134

It seems that this PR introduced a bug in wof_extract. xargs outputs are interleaved when we use it in parallel (see #142).
xargs can't solve this problem alone, there are some post on this here and here.
parallel seems to be the only viable alternative in a multi-process context.

Fixes #142

@missinglink missinglink merged commit 0e2121d into master Oct 9, 2018
@missinglink
Copy link
Member

Cool, thanks for the quick turnaround, it's a pity that xargs couldn't do it, I'd prefer to not have to introduce more dependencies but it is what it is :)

@orangejulius orangejulius deleted the revert-134-joxit/wof-extract branch October 17, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants