feat(blacklist-stream): allow excluding documents via GID blacklist #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,6 +20,10 @@ function insertWofRecord( wof, next ){ | |||
| // sanity check; because WOF | |||
| if( !isValidWofRecord( id, wof ) ) { return next(); } | |||
|
|
|||
| // enforce pelias/blacklist-stream exclusions | |||
| let peliasGID = util.format('whosonfirst:%s:%d', wof['wof:placetype'], id); | |||
There was a problem hiding this comment.
Personally I've been phasing out using util.format for template literals. They're way easier to read in my opinion and allow removing a require.
|
The tests are failing, but this PR didn't break it, and with my testing it does indeed remove blacklisted records from Placeholder. |
orangejulius
added a commit
to pelias/docker
that referenced
this pull request
Jan 19, 2019
Combined with pelias/placeholder#154, this PR add support for blacklisting records from Placeholder.
calpb
pushed a commit
to sorelle/docker
that referenced
this pull request
Mar 29, 2021
Combined with pelias/placeholder#154, this PR add support for blacklisting records from Placeholder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a new stream called blacklist-stream which allows records to be excluded from the build.
See https://github.com/pelias/blacklist-stream for more information on how to use the blacklist file.