Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert adding placetype column #79

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Conversation

missinglink
Copy link
Member

@missinglink missinglink commented Nov 21, 2017

yesterday I merged #73 and today I decided that was possibly not a great idea. this PR reverts part of PR73.

I'm reverting the schema changes due to unnecessary duplication of data which is better normalized:

  • the placetype should not be stored in the token table, it should belong in the docs table instead.
  • each token row has a wofid column which can be joined to the docs table when this string is required.
  • having an additional string column per row in the token table increases the disk requirement.
  • schema changes require every consumer to update their data files to remain compatible.

If we get this merged today it will hopefully prevent anyone from being forced to upgrade due to the schema incompatibility.

@ghost ghost assigned missinglink Nov 21, 2017
@ghost ghost added the in review label Nov 21, 2017
Copy link
Member

@orangejulius orangejulius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Joins FTW. Any idea what the change in disk requirement was? I could imagine the performance impact of the JOIN being less desirable than the increase in storage, but that feels unlikely. Maybe worth checking out though, and its good to have options.

@missinglink missinglink merged commit 78bb5b6 into master Nov 21, 2017
@ghost ghost removed the in review label Nov 21, 2017
@missinglink
Copy link
Member Author

@orangejulius the difference in filesize was 560M vs 535M for 1 extra column on 1.3 million rows.

I'll take care of reverting the master s3 bucket to the correct data

@orangejulius orangejulius deleted the revert_adding_placetype_column branch May 10, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants