Remove peliasQueryFullToken analyzer #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joxit
force-pushed
the
joxit/remove-peliasQueryFullToken
branch
from
8b79964 to
cba6b62
Compare
missinglink
approved these changes
Dec 5, 2019
|
Can we also remove |
|
More info on this PR: #370 |
|
Oh yes, I forgot these two 😄 updated and I have not forgotten the integration tests 😅 |
|
Ok so since pelias/api#1330 was merged 5 months ago, I think that's enough of a deprecation window, these analyzers are now redundant and removing them cleans up the schema a bunch. |
|
Wow |
|
Yeah and 140 from the schema file itself! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we merged our beloved pelias parser, this analyser is no more used 👋.