Merge pull request #289 from pelias/deduplicate_bundle_list

fix: deduplicate bundle list to avoid duplicate downloads
pelias · Sep 21, 2017 · d4cad40 · d4cad40
2 parents a9e1986 + 6b92d6d
commit d4cad40
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/bundleList.js b/src/bundleList.js
@@ -109,7 +109,7 @@ function getBundleList(callback) {
 
   }).on('close', () => {
 
-    const bundles = combineBundleBuckets(roles, bundleBuckets);
+    const bundles = _.sortedUniq(combineBundleBuckets(roles, bundleBuckets));
 
     callback(null, bundles);
 

diff --git a/test/bundleList.js b/test/bundleList.js
@@ -3,6 +3,7 @@
 const tape = require('tape');
 const proxyquire = require('proxyquire');
 const fs = require('fs-extra');
+const _ = require('lodash');
 
 proxyquire.noPreserveCache();
 proxyquire.noCallThru();
@@ -137,6 +138,8 @@ tape('bundlesList tests', (test) => {
         return found;
       });
 
+      t.deepEquals(bundlesList, _.sortedUniq(bundlesList), 'no duplicates should exist in the bundle list');
+
       unexpected.every((type) => {
         const found = bundlesList.some((bundle) => {
           return bundle.indexOf(type) !== -1;