Remove unnecessary compiler toolchain dependencies #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After `better-sqlite3` added support for pre-compiled binaries in https://github.com/JoshuaWise/better-sqlite3/releases/tag/v6.0.0, we no longer need to install a compiler toolchain to run `npm install` in our Docker images. pelias/docker-baseimage#23 is workong on removing the compiler toolchain from our Pelias baseimages. In order for the toolchain to be removed from the whosonfirst image in particular, we also need to remove those dependencies here. Until that PR is merged, this change is effectively a no-op. After, between the two PRs we reduce the size of the whosonfirst docker image from 490MB to 261MB, an impressive 221MB savings!
orangejulius
added a commit
to pelias/placeholder
that referenced
this pull request
Nov 1, 2021
After better-sqlite3 added support for [pre-compiled binaries](https://github.com/JoshuaWise/better-sqlite3/releases/tag/v6.0.0), we no longer need to install a compiler toolchain to run npm install in our Docker images. pelias/docker-baseimage#23 removes the compiler toolchain from our Pelias baseimages. In order for the toolchain to be removed from the Placeholder image in particular, we also need to remove those dependencies here. Similar to the whosonfirst repository in pelias/whosonfirst#532, this change by itself is effectively a no-op. After the baseimage removes the compiler toolchain,the size of the Placeholder docker image goes from 495MB to 266MB, an impressive 229MB savings!
orangejulius
added a commit
to pelias/placeholder
that referenced
this pull request
Nov 5, 2021
After better-sqlite3 added support for [pre-compiled binaries](https://github.com/JoshuaWise/better-sqlite3/releases/tag/v6.0.0), we no longer need to install a compiler toolchain to run npm install in our Docker images. pelias/docker-baseimage#23 removes the compiler toolchain from our Pelias baseimages. In order for the toolchain to be removed from the Placeholder image in particular, we also need to remove those dependencies here. Similar to the whosonfirst repository in pelias/whosonfirst#532, this change by itself is effectively a no-op. After the baseimage removes the compiler toolchain,the size of the Placeholder docker image goes from 495MB to 266MB, an impressive 229MB savings!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
better-sqlite3added support for pre-compiled binaries in v6, we no longer need to install a compiler toolchain to runnpm installin our Docker images.pelias/docker-baseimage#23 removes the compiler toolchain from our Pelias baseimages. In order for the toolchain to be removed from the whosonfirst image in particular, we also need to remove those dependencies here.
Until that PR is merged, this change is effectively a no-op. After, between the two PRs we reduce the size of the whosonfirst docker image from 490MB to 261MB, an impressive 221MB savings!