Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Gtnh #59

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add Gtnh #59

wants to merge 3 commits into from

Conversation

Alfredoes234
Copy link

Description

Adding Greg Tech New Horizons capability using the java 17_21 version.

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. The egg was exported from the panel

@Alfredoes234 Alfredoes234 changed the title Gtnh add Gtnh Jan 28, 2025
@parkervcp
Copy link
Contributor

I am only considering this because the minecraft eggs are in their own repo now and not flooding a single repo with egg merge requests.

@Alfredoes234
Copy link
Author

Did I do something wrong? Or do you mean that now it is separated you can now add more stuff?

@parkervcp
Copy link
Contributor

Now that the minecraft eggs are separate from the rest I am willing to accept more. I turned down them down previously because a lot were covered by what we already had.

More and more are changing to other services so I see there being a need for more specific ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants