Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Touch as namespace plugin #2

Merged
merged 26 commits into from
Apr 28, 2023
Merged

Add Touch as namespace plugin #2

merged 26 commits into from
Apr 28, 2023

Conversation

justinmayer
Copy link
Contributor

@justinmayer justinmayer requested a review from wombelix April 5, 2023 11:21
@justinmayer
Copy link
Contributor Author

@wombelix: You can ignore the failed Lint job — that is happening because the PyPI package does not exist yet, so obviously the link to its PyPI page is broken. This will be resolved once the package has been published.

The test failure seen here seems to occur because we are running tests even though there currently aren't any tests. Do you think you could add at least one test, even if it is simple, in order to resolve that problem?

@justinmayer justinmayer force-pushed the migrate branch 3 times, most recently from 62775e6 to 804964e Compare April 24, 2023 13:28
@justinmayer
Copy link
Contributor Author

@wombelix: I am using this Touch plugin migration endeavor as a test case for switching to Ruff, replacing a bunch of slow & fussy code linters in the process. Would you have a look and let me know if you have any comments? Otherwise I will plan to merge this on Friday, 28 April. Cheers!

@justinmayer
Copy link
Contributor Author

@wombelix: Many thanks for your assistance in migrating this plugin. Much appreciated! ✨

@justinmayer justinmayer merged commit d2ca0c1 into main Apr 28, 2023
@justinmayer justinmayer deleted the migrate branch April 28, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants