Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔒 Fuzzing setup and fixes #754

Closed
wants to merge 13 commits into from
Closed

🔒 Fuzzing setup and fixes #754

wants to merge 13 commits into from

Conversation

pelletier
Copy link
Owner

@pelletier pelletier commented Apr 8, 2022

Finding and fixing bugs in the encoder with Go 1.18 fuzzing.

@pelletier pelletier added the bug Issues describing a bug in go-toml. label Apr 8, 2022
@pelletier pelletier added the fuzzy Issue reported by fuzzy testing, or related to the fuzzing implementation. label Apr 8, 2022
@pelletier pelletier changed the title Encoder: fixes Fuzzing setup and fixes Apr 8, 2022
@moorereason
Copy link
Contributor

Why do you not allow fuzzing on Windows?

@pelletier
Copy link
Owner Author

@moorereason the Go fuzz runner seems to be failing for some internal reason on windows. Figured I’d block it until I can figure out what’s wrong there.

@moorereason
Copy link
Contributor

I tested the Windows fuzzing piece and opened golang/go#52268.

The work-around is some form of these Git settings:

git clone https://github.com/pelletier/go-toml.git --config core.autocrlf=false --config core.eol=lf

@moorereason
Copy link
Contributor

Also, please keep this fixes branch around for a while since I reference it in the upstream issue.

@pelletier
Copy link
Owner Author

Cool! Thank you for looking into this. I've added branch protection on this one to make sure it does not go away. Creating a new PR to get those fixes in. I'll try to play with .gitattributes to see if this issue can be worked-around.

@pelletier pelletier changed the title Fuzzing setup and fixes 🔒 Fuzzing setup and fixes Apr 11, 2022
@pelletier
Copy link
Owner Author

Confirmed that adding an entry to .gitattributes works: bb2fabe.

@pelletier
Copy link
Owner Author

@moorereason since golang/go#52268 has been closed, mind if I close this one and delete the branch too?

@moorereason
Copy link
Contributor

Agreed

@pelletier pelletier closed this Jun 1, 2022
@pelletier pelletier deleted the fixes branch June 1, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues describing a bug in go-toml. fuzzy Issue reported by fuzzy testing, or related to the fuzzing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants