Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore pixel-based scrolling deltas on X11 #1716

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Ignore pixel-based scrolling deltas on X11 #1716

merged 1 commit into from
Jun 8, 2022

Conversation

J5lx
Copy link
Member

@J5lx J5lx commented Jun 5, 2022

MrStevns
MrStevns approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@MrStevns MrStevns left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good to me. I'm thinking right now as it's just x11 it's ok to keep it here but if we need to add more logic for system window behavior, we might have to put it somewhere else.

@MrStevns MrStevns merged commit 5e3c911 into pencil2d:master Jun 8, 2022
@J5lx J5lx deleted the x11-no-pixel-scrolling branch June 9, 2022 13:21
@MrStevns MrStevns added this to the v0.6.7 milestone Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrStevns MrStevns MrStevns approved these changes

Assignees
No one assigned
Labels
Bug Linux Mousewheel
Projects
Bug Fix Priority
Status: No status
Pull Request Priority
Status: Merged
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@J5lx @MrStevns