Ignore Envelopes with Unkown Validators #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebma
reviewed
Aug 5, 2024
pallets/stellar-relay/src/lib.rs
Outdated
| @@ -574,7 +579,8 @@ pub mod pallet { | |||
| .get_tx_set_hash() | |||
| .map_err(|_| Error::<T>::FailedToComputeNonGenericTxSetContentHash)?; | |||
|
|
|||
| validate_envelopes( | |||
| // returns ONLY the validated envelopes | |||
There was a problem hiding this comment.
Suggested change
| // returns ONLY the validated envelopes | |
| // returns ONLY the valid envelopes |
Comment on lines
178
to
181
| log::warn!( | ||
| "Envelope with slot index {}: Node id {:?} is not part of validators list", | ||
| envelope.statement.slot_index, | ||
| envelope.statement.node_id |
There was a problem hiding this comment.
We have the same log statement in the is_node_exist() function so let's rather decide for one instead of having both
| envelope.statement.slot_index, | ||
| envelope.statement.node_id | ||
| ); | ||
| // ignore this ennvelope; continue to the next ones |
There was a problem hiding this comment.
Suggested change
| // ignore this ennvelope; continue to the next ones | |
| // ignore this envelope; continue to the next ones |
| }) | ||
| .ok_or(Error::<T>::MissingExternalizedMessage) | ||
| // it's ok to use unwrap here, since the size will be <= to the provided envelopes | ||
| Ok(UnlimitedVarArray::new(validated_envelopes).unwrap()) |
There was a problem hiding this comment.
You are right that's technically okay to use unwrap() but let's still don't. How about of the unwrap() we return the default() implementation of UnlimitedVarArray which I assume returns an empty array?
Suggested change
| Ok(UnlimitedVarArray::new(validated_envelopes).unwrap()) | |
| Ok(UnlimitedVarArray::new(validated_envelopes).unwrap()) |
b-yap
added a commit
that referenced
this pull request
Aug 5, 2024
|
https://github.com/pendulum-chain/spacewalk/actions/runs/10263219351/job/28396526378?pr=546#step:13:556 Frankfurt on the otherhand: I'm removing Frankfurt in the list, for the meantime. |
ebma
approved these changes
Sep 3, 2024
.github/workflows/ci-main.yml
Outdated
| @@ -7,7 +7,7 @@ name: continuous-integration-main | |||
| jobs: | |||
| ci: | |||
| strategy: | |||
| max-parallel: 2 | |||
| max-parallel: 1 | |||
| _ => false, | ||
| }) | ||
| .ok_or(Error::<T>::MissingExternalizedMessage) | ||
| // it's ok to use unwrap here, since the size will be <= to the provided envelopes |
b-yap
added a commit
that referenced
this pull request
Sep 3, 2024
b-yap
force-pushed
the
544-change-checks-for-unknown-validators-in-stellar-relay-pallet
branch
from
5f84aed to
63dce28
Compare
|
@ebma after I fix the fmt issue, I'll merge it immediately. |
b-yap
deleted the
544-change-checks-for-unknown-validators-in-stellar-relay-pallet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #544
Need to close pendulum-chain/substrate-stellar-sdk#32 before proceeding.
This will ignore validating envelopes with a different
node_id.